FINERACT-802-restrict-client-to-have-single-self-service-user #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santoshconflux
added this to PR Changes Requested/Ready For PR Review
in Fineract 1.4/Mifos 19.12 Fixes
via automation
|
@fynmanoj Can you address the merge conflict so we can merge this for upcoming release? |
aimanoj
force-pushed
the
bug/fineract-802
branch
from
8c6a3de
to
6383320
Compare
|
merge conflict resolved |
luckyman20
requested changes
Aug 14, 2020
There was a problem hiding this comment.
@fynmanoj There's still a merge conflict. Can you please resolve it so we can merge your Pull Request?
| "label.input.maturity.instruction" : "Maturity Instruction", | ||
| "label.input.apply.maturity.instructions" :"Add Maturity Instructions", | ||
| "label.input.transfer.to.account" : "Transfer To Savings Account", | ||
| "validation.msg.fixeddepositaccount.transferToSavingsId.cannot.be.blank" : "Savings account for transfer cannot be blank.", | ||
|
|
||
| "error.msg.user.self.service.user.already.exist" : "Self Service User Id is already created. Go to Admin->Users to edit or delete the self-service user.", |
There was a problem hiding this comment.
Suggested change
| "error.msg.user.self.service.user.already.exist" : "Self Service User Id is already created. Go to Admin->Users to edit or delete the self-service user.", | |
| "error.msg.user.self.service.user.already.exist" : "Self Service User ID is already created. Go to Admin -> Users to edit or delete the self-service user.", |
aimanoj
force-pushed
the
bug/fineract-802
branch
from
6383320
to
17407ae
Compare
luckyman20
approved these changes
Aug 17, 2020
aimanoj
force-pushed
the
bug/fineract-802
branch
from
17407ae
to
5c7f256
Compare
Fineract 1.4/Mifos 19.12 Fixes
automation
moved this from PR Changes Requested/Ready For PR Review
to Done
Aug 17, 2020
|
@fynmanoj Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error message added for the above fineract issue
Related issues and discussion
#{Issue Number}
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Validate the JS and HTML files with
grunt validateto detect errors and potential problems in JavaScript code.Run the tests by opening
test/SpecRunner.htmlin the browser to make sure you didn't break anything.If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
community-app/Contributing.md.