Implement roles and permissions #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorgiozoppi
approved these changes
Jul 19, 2020
There was a problem hiding this comment.
- put a mechanism in a config file instead writing // In production disable...etc.
- We need better way, if exist to define actions...you cannot extend action for everything...doesn't scale: createAction, createSuccessAction...you are smarter than the average javascript programmer. Find a way to write less code. At work we are paid to write less code possible. If iyou find you will gain in mantainence otherwise we keep this. Same thing for the payload
- Now is not here, but this morning i have seen something like 403 hardcode. Never hardcode numbers, use constants, because if you loose on the way...it is a mess.
giorgiozoppi
approved these changes
Jul 19, 2020
|
Try to think on how to write less code possible. |
|
Sure, will keep these points in mind in upcoming prs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement role list view