Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QR code generator and reader implemented #187

Merged
merged 2 commits into from Aug 15, 2020
Merged

QR code generator and reader implemented #187

merged 2 commits into from Aug 15, 2020

Conversation

garvit984
Copy link
Collaborator

@garvit984 garvit984 commented Jun 12, 2020 •
edited

Issue Fix

Fixes #172

Screenshots

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@garvit984 garvit984 changed the title Redesign2 QR code generator and reader implemented Jun 12, 2020
jawidMuhammadi
jawidMuhammadi suggested changes Jun 13, 2020
View reviewed changes
app/build.gradle Show resolved Hide resolved
app/src/main/kotlin/org/mifos/mobile/cn/ui/mifos/QRGenerator.kt Show resolved Hide resolved
app/src/main/kotlin/org/mifos/mobile/cn/ui/mifos/Transfer.kt Outdated Show resolved Hide resolved
app/src/main/res/layout/activity_amount.xml Show resolved Hide resolved
app/src/main/res/layout/activity_scanned.xml Show resolved Hide resolved
app/src/main/res/layout/qrgenerator.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/qrgenerator.xml Outdated Show resolved Hide resolved
@abhijitramesh
Copy link
Collaborator

LGTM, merging to redesign.

@abhijitramesh abhijitramesh merged commit 679b4c6 into openMF:redesign Aug 15, 2020
@garvit984 garvit984 self-assigned this Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawidMuhammadi jawidMuhammadi jawidMuhammadi requested changes

Assignees

@garvit984 garvit984

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garvit984 @abhijitramesh @jawidMuhammadi