feat:added search feature #24
Conversation
|
|
||
| private lateinit var rootView: View | ||
| private lateinit var behavior: BottomSheetBehavior<*> | ||
| lateinit var accountType: AccountType |
There was a problem hiding this comment.
Can't because I am using kotlin setter In another fragment.
| inner class ViewHolder(itemView: View?) : RecyclerView.ViewHolder(itemView) { | ||
|
|
||
| init { | ||
| itemView?.setOnClickListener({ |
There was a problem hiding this comment.
move setOnClickListener in onBindVIewHolder
| } | ||
| } | ||
|
|
||
| var cbStatusSelect = itemView?.cb_status_select |
There was a problem hiding this comment.
var cbStatusSelect = itemView?.cb_status_select it should be var cbStatusSelect = itemView.cb_status_select
same for others
| @@ -68,6 +72,30 @@ class AccountsFragment : MifosBaseFragment(), AccountsContract.View, View.OnClic | |||
| val rootView = inflater.inflate(R.layout.fragment_accounts, container, false) | |||
| accountsPresenter.attachView(this) | |||
|
|
|||
| //listen to setting call | |||
| DataBus.listen(FilterAccountsEvent.SetStatusModelList::class.java).subscribe({ | |||
| } | ||
|
|
||
| override fun onClick(v: View?) { | ||
| when (v?.id) { |
There was a problem hiding this comment.
don't implement onClick, directly use it in onCreateDialog
There was a problem hiding this comment.
@therajanmaurya done in previous PR
| * @since 20/July/2018 | ||
| */ | ||
|
|
||
| class FilterAccountsEvent { |
There was a problem hiding this comment.
Make separate RxEvent Class
|
@therajanmaurya please review. |
ivary43
force-pushed
the
Issue#23
branch
2 times, most recently
from
577f56d
to
df22218
Compare
| @@ -138,7 +138,6 @@ class DashboardActivity : MifosBaseActivity(), View.OnClickListener, NavigationV | |||
| if (fragment is DashboardFragment) { | |||
| setNavigationViewSelectedItem(R.id.item_home) | |||
| } else if(fragment is CustomerAccountFragment) { | |||
| hideToolbarElevation() | |||
There was a problem hiding this comment.
To show the toolbar elevation in accounts section.
| @@ -157,7 +156,6 @@ class DashboardActivity : MifosBaseActivity(), View.OnClickListener, NavigationV | |||
| replaceFragment(DashboardFragment.newInstance(), true, R.id.container) | |||
| } | |||
| R.id.item_accounts -> { | |||
| hideToolbarElevation() | |||
There was a problem hiding this comment.
Same for toolbar elevation
Fixes #23
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.