feat:added login screen and passcode #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@therajanmaurya please review. |
therajanmaurya
requested changes
Jun 4, 2018
app/build.gradle
Outdated
| @@ -98,6 +100,10 @@ dependencies { | |||
| compileOnly "org.glassfish:javax.annotation:10.0-b28" //Required by Dagger2 | |||
| kapt daggerCompiler | |||
|
|
|||
| //butterknife | |||
| implementation "com.jakewharton:butterknife:$rootProject.butterknifeVersion" | |||
| kapt "com.jakewharton:butterknife-compiler:$rootProject.butterknifeVersion" | |||
There was a problem hiding this comment.
We don't nee butterknife anymore, we are working with kotlin extension.
| class LoginActivity : MifosBaseActivity(), LoginContract.View { | ||
|
|
||
|
|
||
| @BindView(R.id.et_username) |
There was a problem hiding this comment.
We are using kotlin extenstion, you can access ui instance using their ids
| @OnClick(R.id.btn_login) | ||
| internal fun login() { | ||
|
|
||
| val username = et_Username.text.toString().trim() |
There was a problem hiding this comment.
Use camel case for naming convention like etUserName
|
|
||
| override fun showProgress() { | ||
| showProgressbar() | ||
| Toaster.show(findViewById(android.R.id.content), getString(R.string.logging_in), Toaster.SHORT) |
therajanmaurya
requested changes
Jun 4, 2018
| } | ||
|
|
||
| override fun startLoginActivity() { | ||
| val i = Intent(this, LoginActivity::class.java) |
| getMvpView.showUserLoginSuccessfully() | ||
| } else { | ||
| getMvpView.hideProgress() | ||
| getMvpView.showError("Error Logging in") |
There was a problem hiding this comment.
don't use hardcoded string, move this string in strings.xml
| internal fun login() { | ||
|
|
||
| val etUsername = et_username.text.toString().trim() | ||
| val etPassword = et_password.text.toString().trim() |
There was a problem hiding this comment.
@ivary43 Please use camel case naming convention in xml, so change the Edit text id in xml like etUserName and etPassword
| android:drawablePadding="@dimen/layout_padding_8dp" | ||
| android:drawableStart="@drawable/ic_person_black_24dp" | ||
| android:hint="@string/username" | ||
| android:id="@+id/et_username" |
There was a problem hiding this comment.
Make edit text it etUserName
| android:drawablePadding="@dimen/layout_padding_8dp" | ||
| android:drawableStart="@drawable/ic_password_black_24dp" | ||
| android:hint="@string/password" | ||
| android:id="@+id/et_password" |
There was a problem hiding this comment.
make edit text id etPassword
| </LinearLayout> | ||
|
|
||
| <Button | ||
| android:id="@+id/btn_login" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.