Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Some parts of the code still use Color() instead of MaterialTheme colors, making the theme inconsistent. #2636

Open
Shermine237 opened this issue Jul 1, 2024 · 0 comments
Open

refactor: Some parts of the code still use Color() instead of MaterialTheme colors, making the theme inconsistent. #2636

Shermine237 opened this issue Jul 1, 2024 · 0 comments

Comments

@Shermine237
Copy link
Contributor

Summary:

Some parts of the code still use Color() instead of MaterialTheme colors, making the theme inconsistent.

Steps to reproduce:

Try changing the theme colors in theme.kt or style.xml and you'll see that some parts of the application remain unchanged.

Expected behaviour:

Use MaterialTheme colors for a uniform theme. This makes it easier to change themes.

Observed behaviour:

In some parts of the code, the colors are hard-coded.
Shermine237 added a commit to Shermine237/mifos-mobile that referenced this issue Jul 1, 2024
@Shermine237
refactor: openMF#2636 Use MaterialTheme colors for a uniform theme
2f09d25
therajanmaurya pushed a commit that referenced this issue Jul 1, 2024
@Shermine237
refactor: #2636 Use MaterialTheme colors for a uniform theme (#2637)
dc68f7a
Shermine237 added a commit to Shermine237/mifos-mobile that referenced this issue Jul 1, 2024
@Shermine237
Merge pull request #4 from openMF/development
42f3518 
refactor: openMF#2636 Use MaterialTheme colors for a uniform theme (openMF#2637)
Shermine237 added a commit to Shermine237/mifos-mobile that referenced this issue Jul 1, 2024
@Shermine237
Merge pull request #5 from openMF/development
013dfd7 
refactor: openMF#2636 Use MaterialTheme colors for a uniform theme (openMF#2637)
akashmeruva9 pushed a commit to akashmeruva9/mifos-mobile that referenced this issue Jul 5, 2024
@Shermine237 @akashmeruva9
# This is a combination of 9 commits.
d98e904 
# This is the 1st commit message:

refactor: openMF#2636 Use MaterialTheme colors for a uniform theme (openMF#2637)

# This is the commit message openMF#2:

refactor: savings module (openMF#2635)

# This is the commit message openMF#3:

refactor: qr module (openMF#2638)

# This is the commit message openMF#4:

A

migrate transfer process screen to compose screen openMF#2583 (openMF#2585)

refactor: qr code display migration (openMF#2609)

Migrate Beneficiary List from XML to compose (openMF#2607)

"Added MIfos Logo to RegistrationScreen" (openMF#2613)

* Added Image to RegistrationScreen

* "Added Image to RegistrationScreen"

Bug: Resolved Swipe Refresh Not Working in RecentTransaction Screen Compose (openMF#2617)

* "Resolved Swipe Refresh Not Working"

* Resolved Swipe Refresh Not Working

* Centered the Swipe Refresh And Added Padding

migrate saving accounts transaction screen to compose openMF#2588 (openMF#2596)

* migrate saving accounts transaction screen to compose openMF#2588

* Update SavingAccountsTransactionTopBar.kt

* init

* init

* refactor: savings accounts screen migration

* refactor: savings accounts screen migration

---------

Co-authored-by: Avneet Singh <avneetmaankiya@gmail.com>

fix#2615 Missing TopAppBar navigation back implementation in AddBeneficiaryScreen (openMF#2616)

fix#2610: Scrolling Disabled in TransferProcessFragment (openMF#2611)

fix#2610: Scrolling Disabled in TransferProcessFragment

fix#2610: Scrolling Disabled in TransferProcessFragment

Beneficiary application (openMF#2618)

Settings screen migration (openMF#2619)

refactor: Registration Module

# This is the commit message openMF#5:

refactor: Login module

# This is the commit message openMF#6:

refactor: Login module

# This is the commit message openMF#7:

refactor: Recent Login module

# This is the commit message openMF#8:

A

migrate transfer process screen to compose screen openMF#2583 (openMF#2585)

refactor: qr code display migration (openMF#2609)

Migrate Beneficiary List from XML to compose (openMF#2607)

"Added MIfos Logo to RegistrationScreen" (openMF#2613)

* Added Image to RegistrationScreen

* "Added Image to RegistrationScreen"

Bug: Resolved Swipe Refresh Not Working in RecentTransaction Screen Compose (openMF#2617)

* "Resolved Swipe Refresh Not Working"

* Resolved Swipe Refresh Not Working

* Centered the Swipe Refresh And Added Padding

migrate saving accounts transaction screen to compose openMF#2588 (openMF#2596)

* migrate saving accounts transaction screen to compose openMF#2588

* Update SavingAccountsTransactionTopBar.kt

* init

* init

* refactor: savings accounts screen migration

* refactor: savings accounts screen migration

---------

Co-authored-by: Avneet Singh <avneetmaankiya@gmail.com>

fix#2615 Missing TopAppBar navigation back implementation in AddBeneficiaryScreen (openMF#2616)

fix#2610: Scrolling Disabled in TransferProcessFragment (openMF#2611)

fix#2610: Scrolling Disabled in TransferProcessFragment

fix#2610: Scrolling Disabled in TransferProcessFragment

Beneficiary application (openMF#2618)

Settings screen migration (openMF#2619)

refactor: Registration Module

# This is the commit message openMF#9:

refactor: Login module

refactor: Login module

refactor: Recent Login module

refactor: transfer process module (openMF#2644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Shermine237