Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Payment hub #1546

Closed
wants to merge 1 commit into from
Closed

Conversation

ShivangiSingh17
Copy link
Contributor

@ShivangiSingh17 ShivangiSingh17 commented Aug 28, 2020

Work left:
Fetching the secondary identifier during the login process.
Adding the payment details in the saving and charges section
Update and Reduce the amount transaction done from the original amount in the Home section.

Screenshots
frame_020_delay-0 1s

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@ShivangiSingh17 ShivangiSingh17 marked this pull request as ready for review August 28, 2020 14:50
@miPlodder
Copy link
Collaborator

@ShivangiSingh17 can we fix the conflict?

@garvit984
Copy link
Contributor

@ShivangiSingh17 Please remove these conflicts so that we can merge this PR.

@Sparsh1212
Copy link
Contributor

Sparsh1212 commented Dec 9, 2020

If this is still up for grab, I would love to work on this. Also, please guide me on how to get started on this.

@garvit984
Copy link
Contributor

You can check the documentation in the Readme. @Sparsh1212

@garvit984
Copy link
Contributor

You can also refer this PR from wallet. openMF/mobile-wallet#1009

@miPlodder
Copy link
Collaborator

miPlodder commented Dec 9, 2020

I don't see any issue mapped to this PR. I am creating an issue for the same. So all the requirements are in one place wrt integration.

@garvit984 Can you add some details for the same here in this ticket, #1617
@Sparsh1212 Please assign the newly created ticket to you. Go ahead with the implementation

Closing this PR, since its depreciated now

@miPlodder miPlodder closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants