fix : migrating fragments from butterknife to viewbinding #2146
Conversation
PratyushSingh07
changed the title
|
@gururani-abhishek do review this whenever you are free |
PratyushSingh07
changed the base branch from
development
to
migrate_to_view_binding
There was a problem hiding this comment.
-
In LocationsFragment.kt, line 8,9 please remove unused Butterknife imports.
-
In ThirdPartyTransferFragment.kt, RecentTransactionsFragment.kt, please double check if errorLayoutBinding is required. I think we can use binding to get a reference of the included error_layout.
-
At some places I've remarked to do view interactions in onViewCreated(), according to android documentation for onCreateView() : "It is recommended to only inflate the layout in this method and move logic that operates on the returned View to onViewCreated()"
Here's the documentation link for better reference. -
In RecentTransactionsFragment.kt bang-bang operator is used with activity and context to assert them as non-null. In all these places(lines : 99,117, 178, 186) please reformat the code to requireActivity() and requireContext().
app/src/main/java/org/mifos/mobile/ui/fragments/ThirdPartyTransferFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/fragments/ThirdPartyTransferFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/fragments/RecentTransactionsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/fragments/RecentTransactionsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/fragments/ThirdPartyTransferFragment.kt
Show resolved
Hide resolved
| recentTransactionsPresenter?.attachView(this) | ||
| sweetUIErrorHandler = SweetUIErrorHandler(activity, rootView) |
There was a problem hiding this comment.
We are using "binding.root" twice, it'll be a great for the purpose of clean coding if we create a val rootView = binding.root, and use it wherever Root View is required. Just a suggestion, totally your call.
danascape
force-pushed
the
fragments-viewbinding
branch
from
6a42c46
to
9995f8c
Compare
danascape
force-pushed
the
fragments-viewbinding
branch
from
9995f8c
to
2ca13a6
Compare
|
hey @jawidMuhammadi do review this whenever you are free |
jawidMuhammadi
merged commit 262160d
into
openMF:migrate_to_view_binding
Fixes #2142
This PR lists the fragments that have been migrated to viewbinding :