fix #2142: migrated guarantor related fragments to viewbinding #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do review this @gururani-abhishek !! |
| binding.tilFirstName.editText?.setText(payload?.firstname) | ||
| binding.tilLastName.editText?.setText(payload?.lastname) | ||
| binding.tilOfficeName.editText?.setText(payload?.officeName) | ||
| (binding.guarantorTypeField.editText as? MaterialAutoCompleteTextView)?.setText(payload?.guarantorType?.value!!) | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
It seems findPreviouslySelectedGurantorType() is not being used anywhere, can be removed after a thorough usage check.
There was a problem hiding this comment.
done @gururani-abhishek , I have also used with(binding)
| .setMessage(getString(R.string.dialog_are_you_sure_that_you_want_to_string, | ||
| getString(R.string.delete_guarantor))) | ||
| .setPositiveButton(getString(R.string.yes), | ||
| DialogInterface.OnClickListener { _, _ -> |
There was a problem hiding this comment.
This redundant SAM constructor can be reformat. Please have a look.
|
Hey @jawidMuhammadi kindly review this as well |
jawidMuhammadi
merged commit 7c30f64
into
openMF:migrate_to_view_binding
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2142
vidma_recorder_04062023_001804.mp4
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.