refactor: Migrate Settings from XML to compose #2601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give 16dp end padding to update endpoint description
|
AvneetSingh2001
requested changes
Jun 11, 2024
Comment on lines
113
to
127
| MaterialAlertDialogBuilder(requireContext()).setTitle(getString(R.string.choose_language)) | ||
| .setSingleChoiceItems( | ||
| resources.getStringArray(R.array.languages), | ||
| getSelectedLanguageIndex(), | ||
| ) { dialog, selectedLanguageIndex -> | ||
| val selectedLanguageValue = | ||
| resources.getStringArray(R.array.languages_value)[selectedLanguageIndex] | ||
|
|
||
| val sharedPreferences = | ||
| PreferenceManager.getDefaultSharedPreferences(requireContext()) | ||
| sharedPreferences.edit() | ||
| .putString(getString(R.string.language_type), selectedLanguageValue).apply() | ||
|
|
||
| dialog.dismiss() | ||
| }.show() |
There was a problem hiding this comment.
Migrate Alert dialogs as well in compose
| private fun changeTheme() { | ||
| val previouslySelectedTheme = prefsHelper.appTheme | ||
|
|
||
| MaterialAlertDialogBuilder(requireContext()).setTitle(getString(R.string.change_app_theme)) |
There was a problem hiding this comment.
migrate dialog to compose
itsPronay
force-pushed
the
settings-1
branch
3 times, most recently
from
c0cdb8b
to
f8250e9
Compare
fix: Migrate Settings from XML to compose openMF#2570 fix: Migrate Settings from XML to compose openMF#2570 refactor: Migrate Settings from XML to compose openMF#2570 fix: Migrate Settings from XML to compose openMF#2570 migrate Settings to compose openMF#2570 migrate Settings to compose openMF#2570
AvneetSingh2001
requested changes
Jun 17, 2024
Comment on lines
125
to
129
| private fun changeLanguage() { | ||
| withMutableSnapshot { | ||
| viewModel.invokeLanguageUpdate = true | ||
| } | ||
| } |
There was a problem hiding this comment.
do this in compose screen.
Comment on lines
131
to
134
| private fun updateLanguage(language: String) { | ||
| val sharedPreferences = PreferenceManager.getDefaultSharedPreferences(requireContext()) | ||
| sharedPreferences.edit().putString(getString(R.string.language_type), language).apply() | ||
| } |
There was a problem hiding this comment.
update shared prefs from compose screen only
Comment on lines
136
to
147
| private fun getSelectedLanguageIndex(): Int { | ||
| var selectedLanguageValue: String? = | ||
| prefsHelper.getString(getString(R.string.language_type), null) | ||
| val languageValuesArray = resources.getStringArray(R.array.languages_value) | ||
|
|
||
| if (!(languageValuesArray.contains(selectedLanguageValue))) { | ||
| if (languageValuesArray.contains(Locale.getDefault().language)) { | ||
| selectedLanguageValue = "System_Language" | ||
| } else selectedLanguageValue = "en" | ||
| } | ||
| return languageValuesArray.indexOf(selectedLanguageValue) | ||
| } |
There was a problem hiding this comment.
in compose screen
Comment on lines
149
to
168
| private fun getCurrentTheme() : Int{ | ||
| return prefsHelper.appTheme | ||
| } | ||
|
|
||
| private fun updateTheme(selectedTheme : Int){ | ||
| prefsHelper.applyTheme(AppTheme.fromIndex(selectedTheme)) | ||
| prefsHelper.applySavedTheme() | ||
| } | ||
|
|
||
| private fun changeTheme(){ | ||
| withMutableSnapshot { | ||
| viewModel.invokeThemeUpdate = true | ||
| } | ||
| } | ||
|
|
||
| private fun updateEndpoint() { | ||
| withMutableSnapshot { | ||
| viewModel.invokeEndpointUpdate = true | ||
| } | ||
| } |
There was a problem hiding this comment.
in compose screen
| ) { | ||
| val context = LocalContext.current | ||
|
|
||
| Scaffold( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2570
Screencast_06_04_2024_03.29.22_AM.webm
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.