Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:modified recylerview item UI #817

Closed
wants to merge 1 commit into from

Conversation

ivary43
Copy link
Contributor

@ivary43 ivary43 commented May 3, 2018

Fixes #795

Please Add Screenshots If there are any UI changes.
screenshot_20180503-235733

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@ivary43
Copy link
Contributor Author

ivary43 commented May 6, 2018

@therajanmaurya , @dilpreet96 please review.

@prashantkh19
Copy link
Contributor

@therajanmaurya @geekanamika I think the table layout is more informative than the proposed layout. However, we can make some minor improvements in the existing layout to make it look better.
What are your views on this?

@therajanmaurya
Copy link
Member

We are going to use this https://github.com/evrencoskun/TableView

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: adding recylerview instead of tables in repayment Schedule and other section of app.
3 participants