New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial setup: gradle, lint, styles, preview app #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-gill
force-pushed
the
main
branch
2 times, most recently
from
June 28, 2022 06:13
53cc562
to
7f96081
Compare
rahul-gill
force-pushed
the
main
branch
2 times, most recently
from
July 2, 2022 07:48
06bce45
to
915b0e6
Compare
droidchef
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please get rid of the .idea
folder
IOhacker
approved these changes
Aug 19, 2022
Grandolf49
approved these changes
Aug 19, 2022
@rahul-gill this PR is approved, please merge |
I don't have access to merge in this repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mifos.DesignSystem.Spacing.*
values for margin and paddingswrap_content
,match_parent
,0dp
andMifos.DesignSystem.Size
values for height and widthcontext.getThemeAttributeColor(R.attr.colorPrimary)
), specifying dp values directly(2.dp
)