Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup: gradle, lint, styles, preview app #3

Merged
merged 12 commits into from Aug 20, 2022

Conversation

rahul-gill
Copy link
Collaborator

@rahul-gill rahul-gill commented Jun 15, 2022

  • theme, typography tokens, size and padding values that the apps will use
  • lint rules:
    • rule to prohibit using some attributes like textColor, textSize, background tint etc.
    • rule to only allow Mifos.DesignSystem.Spacing.* values for margin and paddings
    • rule to only allow wrap_content, match_parent, 0dp and Mifos.DesignSystem.Size values for height and width
    • rule to detect if styles other than the ui library are used
  • some utility functions to do things like getting a color from theme attributes(context.getThemeAttributeColor(R.attr.colorPrimary)), specifying dp values directly(2.dp)
  • profile image view
  • publication on jitpack

@rahul-gill rahul-gill force-pushed the main branch 2 times, most recently from 06bce45 to 915b0e6 Compare July 2, 2022 07:48
Copy link
Member

@droidchef droidchef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get rid of the .idea folder

@Grandolf49
Copy link
Contributor

@rahul-gill this PR is approved, please merge

@rahul-gill
Copy link
Collaborator Author

@rahul-gill this PR is approved, please merge

I don't have access to merge in this repository.

@rahul-gill rahul-gill merged commit f5ee292 into openMF:main Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants