Fixed Issue No #1198 Does not show client details. #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devansh-299
requested changes
Aug 8, 2022
| @@ -17,8 +17,6 @@ | |||
| public interface BaseHomeContract { | |||
|
|
|||
| interface BaseHomeView extends BaseView<BaseHomePresenter> { | |||
|
|
|||
| void showClientDetails(Client client); | |||
There was a problem hiding this comment.
Since we don't have any methods inside the interface, we can skip it altogether. If any requirement arises for the same in the future, we can always create it again
There was a problem hiding this comment.
@devansh-299 if we removed BaseHomeView Interface then we also required to removes the BaseHomePresenter Interface because BaseHomeView Interface extend the property of BaseHomePresenter.
Prashant830
commented
Aug 9, 2022
| @@ -17,8 +17,6 @@ | |||
| public interface BaseHomeContract { | |||
|
|
|||
| interface BaseHomeView extends BaseView<BaseHomePresenter> { | |||
|
|
|||
| void showClientDetails(Client client); | |||
| } | |||
|
|
|||
| interface BaseHomePresenter extends BasePresenter { | |||
There was a problem hiding this comment.
@devansh-299 by chance if we removed both of the interfaces (BaseHomeView , BaseHomePresenter).
then where we add void fetchClientDetails(); method??
devansh-299
approved these changes
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fix
Fixes #1198
Screenshots
Description
In mainActivity, mainPresenter, BaseHomeContract interface I am going to remove the
showclientdetails()function.Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.