fix : Added missing inputType attribute to EditTexts #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where are the project maintainers? |
|
@RajaVamsi11 I think, In your branch have a code conflict . Are u still able to resolved it?? |
rchtgpt
reviewed
Jun 6, 2023
| @@ -19,6 +19,7 @@ | |||
| android:layout_width="match_parent" | |||
| android:layout_height="wrap_content" | |||
| android:hint="@string/pan_id" | |||
| android:inputType="text" | |||
There was a problem hiding this comment.
PAN ID must be an alphanumeric keyboard with only uppercase characters.
rchtgpt
reviewed
Jun 6, 2023
| @@ -91,6 +91,7 @@ | |||
| android:layout_width="match_parent" | |||
| android:layout_height="wrap_content" | |||
| android:hint="@string/virtual_payment_address" | |||
| android:inputType="textEmailAddress" | |||
There was a problem hiding this comment.
Based on my understanding, a VPA looks more like a username than an email address. So, this inputType wouldn't really help our case. We should instead set the inputType to text.
3 tasks
|
Thanks for bringing up the issue, @RajaVamsi11! We're gonna have to close this PR due to inactivity and merge conflicts but we're working to resolve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #473
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.