Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the login of the application #130

Closed
yashk2000 opened this issue Jun 23, 2020 · 0 comments · Fixed by #131
Closed

Refactor the login of the application #130

yashk2000 opened this issue Jun 23, 2020 · 0 comments · Fixed by #131

Comments

@yashk2000
Copy link
Collaborator

I plan to refactor the login of the android application.

Drawbacks in the current implementation:

  • This only works with the demo server. If we change the endpoints and try to use any other server, it won't work.
  • UI could be better
  • Uses khttp, we could use oktthp and retrofit instead for better support since khttp doesn't seem to be maintained.
  • Login credentials aren't saved.
yashk2000 added a commit to yashk2000/ppi-vision that referenced this issue Jun 23, 2020
@yashk2000
Fix openMF#130 Refactor login
bde19f5
This was referenced Jun 23, 2020
Merged
Closed
yashk2000 added a commit to yashk2000/ppi-vision that referenced this issue Jun 23, 2020
@yashk2000
Fix openMF#130 Refactor login
862e1fa
yashk2000 added a commit that referenced this issue Jun 23, 2020
@yashk2000
Merge pull request #131 from yashk2000/refactorLogin
e5281ae 
Fix #130 Refactor login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #130 Refactor login yashk2000/ppi-vision
1 participant
@yashk2000