Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality #189

Closed
yashk2000 opened this issue Aug 30, 2020 · 0 comments · Fixed by #190
Closed

Improve code quality #189

yashk2000 opened this issue Aug 30, 2020 · 0 comments · Fixed by #190

Comments

@yashk2000
Copy link
Collaborator

Describe the chore
Code quality can be improved a bit.

  • Replacing get calls with indexing operator
  • Declare variables whose value isn't updated as val instead of var
  • Removing redundant overrides
  • Use property access syntax where possible
  • Use isEmpty() instead of == 0, etc.
yashk2000 added a commit to yashk2000/ppi-vision that referenced this issue Aug 30, 2020
@yashk2000
Fix openMF#189 Improve code quality
86eedef
@yashk2000 yashk2000 mentioned this issue Aug 30, 2020
Merged
2 tasks
yashk2000 added a commit to yashk2000/ppi-vision that referenced this issue Aug 30, 2020
@yashk2000
Fix openMF#189 Improve code quality
ca67e77
yashk2000 added a commit that referenced this issue Aug 30, 2020
@yashk2000
Fix #189 Improve code quality
19ee840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #189 Improve code quality yashk2000/ppi-vision
1 participant
@yashk2000