Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make variables private #49

Closed
yashk2000 opened this issue Mar 30, 2020 · 0 comments · Fixed by #187
Closed

Make variables private #49

yashk2000 opened this issue Mar 30, 2020 · 0 comments · Fixed by #187

Comments

@yashk2000
Copy link
Collaborator

yashk2000 commented Mar 30, 2020 •
edited

A lot of variables can be made as private but are not. A few examples are responceClicked in ResponseAdapter.kt, items in SelectImageAdapter.kt, listener in ClientSearchAdapter, etc.

I am working on this.
@AroraMehul AroraMehul mentioned this issue Mar 30, 2020
Closed
@yashk2000 yashk2000 mentioned this issue Jun 5, 2020
Merged
yashk2000 added a commit to yashk2000/ppi-vision that referenced this issue Aug 29, 2020
@yashk2000
Fix openMF#49 Make variables and methods private where ever needed
3bc518d
@yashk2000 yashk2000 mentioned this issue Aug 29, 2020
Merged
2 tasks
yashk2000 added a commit that referenced this issue Aug 29, 2020
@yashk2000
Merge pull request #187 from yashk2000/privateVariables
34c7f09 
Fix #49 Make variables and methods private where ever needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #49 Make variables and methods private where ever needed yashk2000/ppi-vision
1 participant
@yashk2000