Changed responsiveness of Login button based on emptiness of field #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashk2000
reviewed
Jun 2, 2020
|
|
||
| binding.etUsername.addTextChangedListener(object : TextWatcher{ | ||
| override fun afterTextChanged(p0: Editable?) { | ||
|
|
There was a problem hiding this comment.
There is no need for the blank line here.
yashk2000
reviewed
Jun 2, 2020
| login_btn.alpha = 1.0F | ||
| login_btn.isEnabled = true | ||
| } | ||
| else{ |
There was a problem hiding this comment.
Suggested change
| else{ | |
| else { |
yashk2000
reviewed
Jun 2, 2020
| if(et_password.text.toString().isNotEmpty() && et_username.text.toString().isNotEmpty()) { | ||
| login_btn.alpha = 1.0F | ||
| login_btn.isEnabled = true | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } else { |
yashk2000
reviewed
Jun 2, 2020
|
|
||
| binding.etPassword.addTextChangedListener(object : TextWatcher{ | ||
| override fun afterTextChanged(p0: Editable?) { | ||
|
|
There was a problem hiding this comment.
No need for the blank line.
yashk2000
reviewed
Jun 2, 2020
| } | ||
|
|
||
| override fun beforeTextChanged(p0: CharSequence?, p1: Int, p2: Int, p3: Int) { | ||
|
|
There was a problem hiding this comment.
No need for the blank line.
yashk2000
reviewed
Jun 2, 2020
| if(et_password.text.toString().isNotEmpty() && et_username.text.toString().isNotEmpty()) { | ||
| login_btn.alpha = 1.0F | ||
| login_btn.isEnabled = true | ||
| } |
There was a problem hiding this comment.
Same changes as above should be made here too.
|
Continued in #91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77
Login button becomes responsive only when both the username and password fields are not empty, otherwise it remains translucent and disabled