Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client charges subsection needs to be improved #1233

Closed
karantakalkar opened this issue Aug 28, 2020 · 10 comments
Closed

Client charges subsection needs to be improved #1233

karantakalkar opened this issue Aug 28, 2020 · 10 comments
Labels
design User interface #hacktoberfest Hacktoberfest refactor Improving the code while maintaining the functionality Stale

Comments

@karantakalkar
Copy link
Collaborator

karantakalkar commented Aug 28, 2020 •
edited

Code, functionality as well as Routing needs to be made consistent with rest of the app.

Screenshot from 2020-08-28 14-59-51

Access charges subsection on clients view page.
https://demo.mifos.io/#/viewclient/1

Screenshot from 2020-09-18 11-19-18
@karantakalkar karantakalkar added bug Something isn't working refactor Improving the code while maintaining the functionality labels Aug 28, 2020
@shobhi1310
Copy link
Contributor

Can I look into this issue? I have sent a PR for #746

@karantakalkar
Copy link
Collaborator Author

Go ahead

@shobhi1310
Copy link
Contributor

Can the issue be elaborated, like which component is it referring to where consistency is needed and what is this page ?

@karantakalkar
Copy link
Collaborator Author

See implementations of tables/forms/dialogs etc in rest of institution section (clients/groups/centers and sub-modules) and make it similar, charges can be accessed in a table, you can find relevant data on demo or staging servers as dev is not that populated.
In case this still seems intricate gain experience with app by contributing to good first issues or report your own issues and submit fix PRs.

@shobhi1310
Copy link
Contributor

image
This page is navigable through the Institution->Clients

How to reach to the page shown in the screenshot of the issue?

@karantakalkar
Copy link
Collaborator Author

Issue updated

@karantakalkar karantakalkar added design User interface #hacktoberfest Hacktoberfest and removed bug Something isn't working labels Oct 1, 2020
@BLasan
Copy link
Contributor

BLasan commented Oct 3, 2020

@karantakalkar Can I work on this?

@karantakalkar
Copy link
Collaborator Author

Go Ahead

@BLasan
Copy link
Contributor

BLasan commented Oct 3, 2020

Go Ahead

What are the changes we have to do? It's working fine btw

BLasan added a commit to BLasan/web-app that referenced this issue Oct 5, 2020
@BLasan
fix: charges overview routing
3181d17 
Fixes: openMF#1233
@BLasan BLasan mentioned this issue Oct 5, 2020
Closed
2 tasks
BLasan added a commit to BLasan/web-app that referenced this issue Oct 5, 2020
@BLasan
fix: client charges overview
c44d6ce 
Fixes: openMF#1233
@BLasan
Copy link
Contributor

BLasan commented Oct 18, 2020

@karantakalkar Please review

@github-actions github-actions bot added the Stale label Oct 7, 2022
@github-actions github-actions bot closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design User interface #hacktoberfest Hacktoberfest refactor Improving the code while maintaining the functionality Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shobhi1310 @BLasan @karantakalkar