You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
~/git/openMSX $ make OPENMSX_FLAVOUR=unittest
Using Python: python3
A CXXFLAGS:
B CXXFLAGS:
C CXXFLAGS: -O3 -g -DUNITTEST -IContrib/catch2 -fsanitize=address
D CXXFLAGS: -O3 -g -DUNITTEST -IContrib/catch2 -fsanitize=address
Build configuration:
Platform: x86_64-linux
Flavour: unittest
Compiler: x86_64-pc-linux-gnu-g++
CXXFLAGS: -O3 -g -DUNITTEST -IContrib/catch2 -fsanitize=address
Subset: full build
But doing the same with CXXFLAGS specified from the caller yields a build environment where all CXXFLAGS are set to the caller's:
~/git/openMSX $ make CXXFLAGS="user flags" OPENMSX_FLAVOUR=unittest
Using Python: python3
A CXXFLAGS: user flags
B CXXFLAGS: user flags
C CXXFLAGS: user flags
D CXXFLAGS: user flags
Build configuration:
Platform: x86_64-linux
Flavour: unittest
Compiler: x86_64-pc-linux-gnu-g++
CXXFLAGS: user flags
Subset: full build
This doesn't only affect the unittest build, but it does affect it somewhat acutely because it ends up overwriting the -DUNITTEST setting, which breaks some tests.
The text was updated successfully, but these errors were encountered:
Reported apparent CXXFLAGS handling regression below. Working around it
with sed, as is already done with LDFLAGS. Add python3_12.
See-Also: openMSX/openMSX#1563
Signed-off-by: John Helmert III <ajak@gentoo.org>
I've added a small patch to my tree to help demonstrate the issue:
A raw unittest invocation yields:
But doing the same with CXXFLAGS specified from the caller yields a build environment where all CXXFLAGS are set to the caller's:
This doesn't only affect the unittest build, but it does affect it somewhat acutely because it ends up overwriting the
-DUNITTEST
setting, which breaks some tests.The text was updated successfully, but these errors were encountered: