Remove using namespace std and add std:: qualifications where needed (#…

…2092)

`using namespace std;` is generally an antipattern as it imports a huge
number of common names into the global namespace. We already qualify
names with std:: in majority of cases and `using namespace std` is not
actually needed most of the time. This commit addresses a small number
of remaining cases where std:: is missing and removes all `using
namespace std`.

src/openMVG/exif/exif_IO_test.cpp

@@ -14,7 +14,6 @@
 #include <iostream>
 #include <memory>
 
-using namespace std;
 using namespace openMVG;
 using namespace openMVG::exif;
 

src/openMVG/features/features_test.cpp

@@ -18,9 +18,6 @@
 
 using namespace openMVG;
 using namespace openMVG::features;
-using namespace std;
-
-using std::string;
 
 // Define a feature and a container of features
 using Feature_T = SIOPointFeature;

src/openMVG/features/image_describer_test.cpp

@@ -21,9 +21,6 @@
 
 using namespace openMVG;
 using namespace openMVG::features;
-using namespace std;
-
-using std::string;
 
 bool SaveAndLoad
 (

src/openMVG/geometry/frustum_box_intersection_test.cpp

@@ -22,7 +22,6 @@
 using namespace openMVG;
 using namespace openMVG::geometry;
 using namespace openMVG::geometry::halfPlane;
-using namespace std;
 
 //--
 // Box/Camera frustum intersection unit test

src/openMVG/geometry/frustum_intersection_test.cpp

@@ -21,7 +21,6 @@
 using namespace openMVG;
 using namespace openMVG::geometry;
 using namespace openMVG::geometry::halfPlane;
-using namespace std;
 
 //--
 // Camera frustum intersection unit test

src/openMVG/geometry/half_space_intersection_test.cpp

@@ -17,7 +17,6 @@
 
 using namespace openMVG;
 using namespace openMVG::geometry::halfPlane;
-using namespace std;
 
 TEST(HALF_PLANE, ExistingSubspace) {
 

src/openMVG/geometry/rigid_transformation3D_srt_test.cpp

@@ -13,7 +13,6 @@
 
 using namespace openMVG;
 using namespace openMVG::geometry;
-using namespace std;
 
 TEST(SRT_precision, Experiment_ScaleOnly) {
 

src/openMVG/image/image_filtering_test.cpp

@@ -15,7 +15,6 @@
 
 using namespace openMVG;
 using namespace openMVG::image;
-using namespace std;
 
 TEST(Image, Convolution)
 {

src/openMVG/image/image_test.cpp

@@ -14,7 +14,6 @@
 
 #include <iostream>
 
-using namespace std;
 using namespace openMVG;
 using namespace openMVG::image;
 
@@ -26,12 +25,12 @@ TEST(Image, Basis)
   imaGray(2,2) = 2;
   imaGray(5,0) = 2;
 
-  cout << imaGray << endl << endl;
+  std::cout << imaGray << std::endl << std::endl;
   //-- Get raw ptr to image data :
   const unsigned char * ptr = imaGray.data();
   ((unsigned char*)ptr)[0] = 2;
-  fill(((unsigned char*)ptr+9*10),((unsigned char*)ptr+10*10),2);
-  cout << "After" << endl << imaGray;
+  std::fill(((unsigned char*)ptr+9*10),((unsigned char*)ptr+10*10),2);
+  std::cout << "After" << std::endl << imaGray;
 
   // Construction by re-copy
   Image<unsigned char> imageGray2(imaGray);

src/openMVG/linearProgramming/lInfinityCV/global_translations_fromTij_test.cpp

@@ -16,7 +16,6 @@
 using namespace openMVG;
 using namespace openMVG::linearProgramming;
 using namespace lInfinityCV;
-using namespace std;
 
 TEST(translation_averaging, globalTi_from_tijs) {
 

src/openMVG/linearProgramming/lInfinityCV/global_translations_fromTriplets_test.cpp

@@ -16,7 +16,6 @@
 using namespace openMVG;
 using namespace openMVG::linearProgramming;
 using namespace lInfinityCV;
-using namespace std;
 
 TEST(translation_averaging, globalTi_from_tijs_Triplets) {
 

src/openMVG/matching/matching_filters_test.cpp

@@ -14,18 +14,17 @@
 
 using namespace openMVG;
 using namespace openMVG::matching;
-using namespace std;
 
 /// Sorted vector intersection (increasing order)
 TEST( matching, setIntersection)
 {
   const int tab0[] = {0, 1, 2, 3, 4, 5, 6, 7};
   const int tab1[] = {0, 1, 8, 3, 4, 9, 6, 7};
-  const set<int> vec_0(tab0, tab0+8);
-  const set<int> vec_1(tab1, tab1+8);
+  const std::set<int> vec_0(tab0, tab0+8);
+  const std::set<int> vec_1(tab1, tab1+8);
   /// Array must be sorted
 
-  vector<int> vec_intersect;
+  std::vector<int> vec_intersect;
   IntersectMatches(vec_0.begin(), vec_0.end(),
     vec_1.begin(), vec_1.end(),
     vec_intersect);

src/openMVG/matching/matching_test.cpp

@@ -19,7 +19,6 @@
 #include "testing/testing.h"
 
 #include <iostream>
-using namespace std;
 
 using namespace openMVG;
 using namespace matching;
@@ -48,7 +47,7 @@ TEST(Matching, ArrayMatcherBruteForce_NN)
 
   const float query[] = {2};
   IndMatches vec_nIndice;
-  vector<float> vec_fDistance;
+  std::vector<float> vec_fDistance;
   EXPECT_TRUE( matcher.SearchNeighbours(query,1, &vec_nIndice, &vec_fDistance, 5) );
 
   EXPECT_EQ( 5, vec_nIndice.size());
@@ -97,7 +96,7 @@ TEST(Matching, ArrayMatcher_Kdtree_Flann_Simple__NN)
 
   const float query[] = {2};
   IndMatches vec_nIndice;
-  vector<float> vec_fDistance;
+  std::vector<float> vec_fDistance;
   const int NN = 5;
   EXPECT_TRUE( matcher.SearchNeighbours(query, 1, &vec_nIndice, &vec_fDistance, NN) );
 
@@ -129,7 +128,7 @@ TEST(Matching, ArrayMatcher_Hnsw_Simple__NN)
 
   const float query[] = {2};
   IndMatches vec_nIndice;
-  vector<float> vec_fDistance;
+  std::vector<float> vec_fDistance;
   const int NN = 5;
   EXPECT_TRUE( matcher.SearchNeighbours(query, 1, &vec_nIndice, &vec_fDistance, NN) );
 

src/openMVG/matching/metric_test.cpp

@@ -14,8 +14,6 @@
 
 #include <iostream>
 
-using namespace std;
-
 using namespace openMVG;
 using namespace matching;
 

src/openMVG/matching_image_collection/Pair_Builder_test.cpp

@@ -13,7 +13,6 @@
 #include <iostream>
 
 using namespace openMVG;
-using namespace std;
 
 // Check pairs follow a weak ordering pair.first < pair.second
 template<typename IterablePairs>

src/openMVG/multiview/rotation_averaging_test.cpp

@@ -61,8 +61,6 @@ TEST ( rotation_averaging, ClosestSVDRotationMatrixNoisy )
 //     1
 TEST ( rotation_averaging, RotationLeastSquare_3_Camera)
 {
-  using namespace std;
-
   //--
   // Setup 3 camera that have a relative orientation of 120 degree
   // Set Z axis as UP Vector for the rotation
@@ -162,8 +160,6 @@ TEST ( rotation_averaging, RefineRotationsL2_CompleteGraph)
 
 TEST ( rotation_averaging, RefineRotationsAvgL1IRLS_SimpleTriplet)
 {
-  using namespace std;
-
   //--
   // Setup 3 camera that have a relative orientation of 120 degree
   // Set Z axis as UP Vector for the rotation

src/openMVG/multiview/solver_fundamental_kernel_test.cpp

@@ -37,7 +37,6 @@
 #include <numeric>
 
 using namespace openMVG;
-using namespace std;
 
 // Check that sin(angle(a, b)) < tolerance.
 template<typename A, typename B>
@@ -86,9 +85,9 @@ bool ExpectKernelProperties(const Mat &x1,
                             Mat3 *F_expected = nullptr) {
   bool bOk = true;
   Kernel kernel(x1, x2);
-  vector<uint32_t> samples(x1.cols());
+  std::vector<uint32_t> samples(x1.cols());
   std::iota(samples.begin(), samples.end(), 0);
-  vector<Mat3> Fs;
+  std::vector<Mat3> Fs;
   kernel.Fit(samples, &Fs);
 
   bOk &= (!Fs.empty());

src/openMVG/multiview/solver_homography_kernel_test.cpp

@@ -33,12 +33,11 @@
 
 #include <vector>
 
-using namespace std;
 using namespace openMVG;
 
 TEST(HomographyKernelTest, Fitting_Unnormalized) {
   // Define 3 knows homographies (Use as GT).
-  vector<Mat3> H_gt(3);
+  std::vector<Mat3> H_gt(3);
 
   H_gt[0] = Mat3::Identity();
   H_gt[1] << 1,  0, -4, // Affine homography motion
@@ -60,13 +59,13 @@ TEST(HomographyKernelTest, Fitting_Unnormalized) {
 
     homography::kernel::UnnormalizedKernel kernel(x, y);
 
-    vector<uint32_t> samples = {0,1,2,3,4};
+    std::vector<uint32_t> samples = {0,1,2,3,4};
     for (
       Mat::Index j = 4;
       static_cast<Mat::Index>(samples.size()) < x.cols();
       samples.push_back(j++))
     {
-      vector<Mat3> Hs;
+      std::vector<Mat3> Hs;
       kernel.Fit(samples, &Hs);
       CHECK_EQUAL(1, Hs.size());
       // Check that found matrix is equal to the GT
@@ -77,7 +76,7 @@ TEST(HomographyKernelTest, Fitting_Unnormalized) {
 
 TEST(HomographyKernelTest, Fitting_Normalized) {
   // Define 3 knows homographies (Use as GT).
-  vector<Mat3> H_gt(3);
+  std::vector<Mat3> H_gt(3);
 
   H_gt[0] = Mat3::Identity();
   H_gt[1] << 1,  0, -4, // Affine homography motion
@@ -99,13 +98,13 @@ TEST(HomographyKernelTest, Fitting_Normalized) {
 
     homography::kernel::Kernel kernel(x, y);
 
-    vector<uint32_t> samples = {0,1,2,3,4};
+    std::vector<uint32_t> samples = {0,1,2,3,4};
     for (
       Mat::Index j = 4;
       static_cast<Mat::Index>(samples.size()) < x.cols();
       samples.push_back(j++))
     {
-      vector<Mat3> Hs;
+      std::vector<Mat3> Hs;
       kernel.Fit(samples, &Hs);
       CHECK_EQUAL(1, Hs.size());
       // Check that found matrix is equal to the GT

src/openMVG/multiview/solver_resection_kernel.cpp

@@ -15,8 +15,6 @@ namespace openMVG {
 namespace resection {
 namespace kernel {
 
-using namespace std;
-
 void translate
 (
   const Mat3X & X,
@@ -71,7 +69,7 @@ void SixPointResectionSolver::Solve
 (
   const Mat &pt2D,
   const Mat &pt3d,
-  vector<Mat34> *Ps,
+  std::vector<Mat34> *Ps,
   bool bcheck
 )
 {

src/openMVG/multiview/translation_averaging_test.cpp

@@ -18,7 +18,6 @@
 #include <vector>
 
 using namespace openMVG;
-using namespace std;
 
 TEST(translation_averaging, globalTi_from_tijs_Triplets_softL1_Ceres) {
 

src/openMVG/multiview/triangulation_test.cpp

@@ -14,7 +14,6 @@
 #include "testing/testing.h"
 
 using namespace openMVG;
-using namespace std;
 
 TEST(Triangulation, TriangulateDLT) {
 

src/openMVG/numeric/l1_solver_test.cpp

@@ -16,7 +16,6 @@
 #include <random>
 
 using namespace openMVG;
-using namespace std;
 
 TEST(L1Solver_ADMM, Decoding)
 {

src/openMVG/numeric/lm_test.cpp

@@ -21,7 +21,6 @@
 
 using namespace openMVG;
 using namespace svg;
-using namespace std;
 
 // Implementation of the problem found here:
 // digilander.libero.it/foxes/optimiz/Optimiz1.htm

src/openMVG/numeric/numeric_test.cpp

@@ -36,7 +36,6 @@
 #include <set>
 
 using namespace openMVG;
-using namespace std;
 
 //-- Assert that stream interface is available
 TEST ( TinyMatrix, print )

src/openMVG/robust_estimation/gms_filter_test.cpp

@@ -13,7 +13,6 @@
 
 using namespace openMVG;
 using namespace openMVG::robust;
-using namespace std;
 
 TEST(GMSFilter, borderCases)
 {