(trivial) Remove using namespace std and add std:: qualifications in few places where needed #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmoulon
reviewed
Jul 11, 2022
| @@ -15,6 +15,7 @@ Acer CS-5531;5.75 | |||
| Acer CS-6530;5.75 | |||
| Acer CS-6531;5.75 | |||
| Acer CU-6530;5.75 | |||
| samsung SM-G973F;5.75 | |||
There was a problem hiding this comment.
Could we remove this modification from this PR?
There was a problem hiding this comment.
I'm sorry, this was included due to an oversight. Fixed now.
`using namespace std;` is generally an antipattern as it imports a huge number of common names into the global namespace. We already qualify names with std:: in majority of cases and `using namespace std` is not actually needed most of the time. This commit addresses a small number of remaining cases where std:: is missing and removes all `using namespace std`.
p12tic
force-pushed
the
remove-using-namespace-std
branch
from
b0e20bf
to
767b8c0
Compare
|
Thank you. Everything looks good. Thank you for the PR, the contribution. Looking forward your next contribution 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using namespace std;is generally an antipattern as it imports a huge number of common names into the global namespace. We already qualify names with std:: in majority of cases andusing namespace stdis not actually needed most of the time. This commit addresses a small number of remaining cases where std:: is missing and removes allusing namespace std.