Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing mkdir command in Makefile #341

Merged
merged 1 commit into from May 5, 2022

Conversation

dzatoah
Copy link
Contributor

@dzatoah dzatoah commented Apr 22, 2022

Hey,

This PR fixes a missing mkdir command in Makefile.

By the way:
We are currently working on packaging openNDS for Debian.
See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1009368

For the Debian package we will use $(DESTDIR)/lib/systemd/system/ instead of $(DESTDIR)/etc/systemd/system.
Do you wish that I include this change in this PR too?

Signed-off-by: Daniel Teichmann <daniel.teichmann@das-netzwerkteam.de>
@bluewavenet
Copy link
Member

@dzatoah
I think the missing mkdir is only an issue for Debian and Debian based, because it does not already exist there. I don't see adding it in anyway being a problem though.

For the Debian package we will use $(DESTDIR)/lib/systemd/system/ instead of $(DESTDIR)/etc/systemd/system.

This should not be incorporated into the generic Makefile as it will break other distros. Specific requirements of a distro should be included in a specific area for the distro. This is already done for both Debian and OpenWrt (see linux_debian and linux_openwrt folders).

@sunweaver
Copy link
Contributor

@bluewavenet For creating packages (independent from the distribution), the upstream Makefile (or whatever build system is used by upstream) must assure that the complete directory structure required for putting upstream files in gets created by that Makefile.

With RPM and Debian packaging, the make install target gets created on an empty DESTDIR and the upstream Makefile is then responsible for creating everything in DESTDIR.

This is definitely not a Debian-specific issue. You cannot assume in Makefile's install target for any directories being already present.

(says sunweaver, [1])

[1] https://qa.debian.org/developer.php?email=sunweaver%40debian.org

@bluewavenet bluewavenet merged commit 52edcc8 into openNDS:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants