Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Documentation=man:opennds' to unit section of service file. #344

Conversation

dzatoah
Copy link
Contributor

@dzatoah dzatoah commented Apr 22, 2022

This PR adds 'Documentation=man:opennds' to unit section of service file.

…ction of service file.

Signed-off-by: Daniel Teichmann <daniel.teichmann@das-netzwerkteam.de>
@bluewavenet
Copy link
Member

This is Debian specific and will not work for other distros. See my comments on #341

@sunweaver
Copy link
Contributor

@bluewavenet The Documentation=man: is not Debian-specific.

See https://www.freedesktop.org/software/systemd/man/systemd.unit.html

(which is the upstream documentation and it lists the "man:" prefix as valid prefix).

@bluewavenet
Copy link
Member

bluewavenet commented Apr 23, 2022

@sunweaver

The Documentation=man: is not Debian-specific.

This is true, but
Documentation=man:opennds
is Debian specific because the man page is only generated for Debian.

The best way forward is to remove the linux_debian/doc folder from the source.
See PR #346

@sunweaver
Copy link
Contributor

Ah, specific to your Debian package build recipe. Now I understand. Why don't you ship the man page as part of the openNDS upstream code. Man pages are not Debian-specific, but useful on most other distros, as well.

@bluewavenet
Copy link
Member

The Debian specific man page is now removed. See PR #346

@bluewavenet bluewavenet closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants