Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thirdparty library: toml11 by Toru Niina #1148

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Thirdparty library: toml11 by Toru Niina #1148

merged 3 commits into from
Dec 1, 2021

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Nov 18, 2021 •
edited by ax3l

Needed for #1146 (toml).
If needed, I can also remove all commits but the first and keep those inside #1146 instead

@ax3l
Copy link
Member

ax3l commented Dec 1, 2021 •
edited

Thanks a lot!

If needed, I can also remove all commits but the first and keep those inside #1146 instead

Applied this now in 06386e6 and rebased this PR :)

I fixed tiny formatting problems in the README, Changelog and CMake on the way.

@ax3l ax3l self-requested a review December 1, 2021 22:20
@ax3l ax3l self-assigned this Dec 1, 2021
@ax3l ax3l added the third party third party libraries that are shipped and/or linked label Dec 1, 2021
@ax3l ax3l enabled auto-merge (squash) December 1, 2021 22:26
@ax3l ax3l merged commit 53f8018 into openPMD:dev Dec 1, 2021
@ax3l ax3l mentioned this pull request Dec 1, 2021
Merged
8 tasks
@ax3l ax3l mentioned this pull request Mar 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
third party third party libraries that are shipped and/or linked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@franzpoeschel @ax3l