New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read backend configuration from .toml files #1146
Conversation
f2348aa
to
462d83d
Compare
When I leave out the
I'll have to try using a standalone toml11 example to see if there is a bug on Windows. |
b30930f
to
8632d58
Compare
Rebased after #1148 was merged :) |
742b9ce
to
dbb842c
Compare
Rebased and up for review :) @ax3l |
Thank you, the code looks great to me! ✨ In order to finalize the PR for merge, can you please:
? :) |
Still in jetlag? :D Yep, those are good suggestions. I'll try to work the TOML configuration into the docs (since both are equivalent, I think I'll not duplicate everything, but have some examples for TOML here and there), also I think for user-facing examples you mean something under the |
I've now added documentation and a new example based on the streaming examples. |
9efd67b
to
94364d9
Compare
This pull request introduces 1 alert when merging 94364d9 into 05eff02 - view on LGTM.com new alerts:
|
55f7845
to
1609dd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, minor final updates inline :)
Also a small collision from #1162 in src/IO/ADIOS/CommonADIOS1IOHandler.cpp
now.
It seems to prefer this at least on Windows
This way we don't confuse users when they use TOML but get a JSON-based error message.
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
3c5a3d3
to
cc63e04
Compare
rebased |
Approach for implementation: Read from .toml file, but convert to nlohmann::json internally
Config files are much more readable in TOML:
TODO:
Dataset
config too (how to do that?)Make TOML an optional dependency?discussed: compiler coverage here is good.CommonADIOS1IOHandlerImpl< ChildClass >::initJson()
after merging Fix reading of dataset-specific configuration in ADIOS1 #1162 (there will be no merge conflict)