Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ZipGenotypingFiles #527

Merged
merged 6 commits into from
Apr 19, 2020
Merged

Refactor ZipGenotypingFiles #527

merged 6 commits into from
Apr 19, 2020

Conversation

tsujigiri
Copy link
Collaborator

No description provided.

houndci-bot
houndci-bot reviewed Apr 18, 2020
View reviewed changes
spec/workers/zip_genotyping_files_spec.rb Show resolved Hide resolved
spec/workers/zip_genotyping_files_spec.rb Show resolved Hide resolved
app/workers/zip_genotyping_files.rb Outdated Show resolved Hide resolved
app/workers/zip_genotyping_files.rb Outdated Show resolved Hide resolved
app/workers/zip_genotyping_files.rb Outdated Show resolved Hide resolved
gedankenstuecke
gedankenstuecke approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@gedankenstuecke gedankenstuecke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And thanks for doing this, I think this has been an open issue for a loooooong time 😂

@tsujigiri tsujigiri merged commit de1fd19 into master Apr 19, 2020
@tsujigiri tsujigiri deleted the refactor-zip_genotyping_files branch April 19, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@gedankenstuecke gedankenstuecke gedankenstuecke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsujigiri @gedankenstuecke @houndci-bot