No progress dispatching during progress #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only storage and software services are affected. * The manager service still dispatch those actions as it is protected by the safe_run mechanism.
joseivanlopez
approved these changes
Sep 11, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Related to bsc#1215197.
Agama tries to start the installation while busy in the config phase. We have not reproduced the problem but suspect that dispatching new actions during progress reporting is problematic.
Solution
Stop dispatching actions during progress in the progress and software services. The manager still dispatches those actions, as "destructive" actions are protected using the
safe_runmechanism.