Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No progress dispatching during progress #747

Merged
merged 3 commits into from
Sep 11, 2023
Merged

No progress dispatching during progress #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb1fa48
Do not dispatch on progress changes
imobachgs Sep 11, 2023
dd1083c
Finish the progress when config or install phases fail
imobachgs Sep 11, 2023
4c16765
Update the changes file
imobachgs Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion service/lib/agama/dbus/software_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ def initialize(config, logger = nil)
@logger = logger || Logger.new($stdout)
@bus = Bus.current
@backend = Agama::Software::Manager.new(config, logger)
@backend.on_progress_change { dispatch }
end

# Starts software service. It does more then just #export method.
Expand Down
4 changes: 1 addition & 3 deletions service/lib/agama/dbus/storage_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,7 @@ def dispatch
attr_reader :logger

def manager
@manager ||= Agama::Storage::Manager.new(config, logger).tap do |manager|
manager.on_progress_change { dispatch }
end
@manager ||= Agama::Storage::Manager.new(config, logger)
end

# @return [::DBus::ObjectServer]
Expand Down
2 changes: 2 additions & 0 deletions service/lib/agama/manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def config_phase
# TODO: report errors
ensure
service_status.idle
finish_progress
end

# Runs the install phase
Expand Down Expand Up @@ -126,6 +127,7 @@ def install_phase
logger.error "Installation error: #{e.inspect}. Backtrace: #{e.backtrace}"
ensure
service_status.idle
finish_progress
end
# rubocop:enable Metrics/AbcSize

Expand Down
6 changes: 6 additions & 0 deletions service/package/rubygem-agama.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Mon Sep 11 11:28:05 UTC 2023 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

- The software and the storage services do not dispatch actions
during progress reporting anymore (related to bsc#1215197).

-------------------------------------------------------------------
Wed Sep 6 08:02:35 UTC 2023 - José Iván López González <jlopez@suse.com>

Expand Down