Prevent tiny installation font (bsc#1124508) #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, could you change title font size from px to pt too, so it scales the same way? |
|
Perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugzilla
https://bugzilla.suse.com/show_bug.cgi?id=1124508
Problem
Since the latest change to the "Source Sans Pro" font, the font in the YaST installer has become too tiny.
Cause
That font appears to have slightly different font metrics to the prior default font, so the default size that Qt chooses if nothing is specified (10 pt as far as I can tell) does not fit anymore. The installation widget style sheet did not provide an explicit font size; it relied on whatever Qt chose as the default.
Fix
Explicitly set a well-defined font size. Since this font appears to have different font metrics, 10.5 pt turned out to be a reasonable value.
Screenshots
Before (Tiny Font)
Now (10.5 pt)
For Comparison: Leap 15.0
Complete Set of Screenshots
Before
Now (10.5 pt)
For Comparison: Leap 15.0