Run optipng over pngs #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason we stopped doing that in the past was a tendency for optipng to produce different enough pngs that openQA cared and so we kept on having to reneedle just because of a new build If you are confident this won’t happen, LGTM |
|
The only part that is checked with openQA from this PR is GRUB, afaik Plymouth and Xfce splash are completely ignored. |
|
IIRC it was different in the olden times I am referring to.. 👴 |
|
It's the first time I hear that optipng changes pngs in a way that is visible at all. All it does is comparing different compression settings - if it changes the resulting pixels, it's a critical bug. Especially as openqa calls optipng on needles you create, it would be very problematic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.