Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should keycombo's action attr be allowed? #50

Closed
ghost opened this issue Mar 16, 2018 · 1 comment
Closed

Should keycombo's action attr be allowed? #50

ghost opened this issue Mar 16, 2018 · 1 comment
Assignees
@tomschr
Labels
bug 🐛 Something isn't working as expected
Milestone
1.0.3

Comments

@ghost
Copy link

ghost commented Mar 16, 2018 •
edited by ghost
Loading

Novdoc does not allow the action attribute in keycombo. GeekoDoc currently does. Should it?
(found by @cwickert)
@tomschr tomschr self-assigned this Apr 27, 2018
@tomschr tomschr added the bug 🐛 Something isn't working as expected label Apr 27, 2018
@tomschr
Copy link
Contributor

tomschr commented Apr 27, 2018

Hmn, good question. At the moment, the stylesheet cannot handle this. Probably a good idea to remove it.

@tomschr tomschr added this to the 1.0.3 milestone Apr 27, 2018
tomschr added a commit that referenced this issue Apr 27, 2018
@tomschr
Fix #50: remove action in keycombo
dad93e9
tomschr added a commit that referenced this issue Apr 27, 2018
@tomschr
Testcase for #50
622a7ba
@tomschr tomschr mentioned this issue Apr 27, 2018
Merged
tomschr added a commit to SUSE/doc-sle that referenced this issue Apr 27, 2018
@tomschr
Remove action attribute from <keycombo>
baeb7ad 
This is needed to be compatible with the upcoming change in
openSUSE/geekodoc#50
@ghost ghost closed this as completed in 621d96b May 15, 2018
ghost pushed a commit that referenced this issue May 15, 2018
@tomschr
Testcase for #50
6d5910c
tomschr added a commit that referenced this issue Jun 22, 2018
@tomschr
Merge tag 'v1.0.3' into develop
cbbf37e 
Bugfix release 1.0.3

Geekodoc:
 * disallow xml:id on child elements of table (#39)
 * Missing "fig" value in format attribute of imagedta (#43)
 * add missing holder tag (#46)
 * integrate its:translate (#45)
 * output XSLT stylesheet from Schematron validation (#49)
 * remove action in keycombo (#50)
 * reduce content model in screen (#51)
 * remove procedure from table entry (#56)

 Others:
 * Make sure GeekoDoc is available in OBS/IBS, so we can use
   it from DC file (#33)

Novdoc:
  no changes
cwickert added a commit to SUSE/doc-sle that referenced this issue Oct 22, 2020
@cwickert
Remove 'action' attribute from keykombo to fix validation with geekodoc
94d6157 
1.0.3 (openSUSE/geekodoc#50)
cwickert added a commit to SUSE/doc-sle that referenced this issue Oct 27, 2020
@cwickert
Remove 'action' attribute from keykombo to fix validation with geekodoc
f85000b 
1.0.3 (openSUSE/geekodoc#50)
cwickert added a commit to SUSE/doc-sle that referenced this issue Oct 27, 2020
@cwickert
Remove 'action' attribute from keykombo to fix validation with geekodoc
2268f2f 
1.0.3 (openSUSE/geekodoc#50)
taroth21 added a commit to SUSE/doc-sle that referenced this issue Oct 30, 2020
@taroth21
Remove 'action' attribute from keykombo to fix validation with geekodoc
b85a572 
1.0.3 (openSUSE/geekodoc#50)

(cherry picked from commit 94d6157)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomschr tomschr

Labels
bug 🐛 Something isn't working as expected
Projects
None yet
Milestone
1.0.3
Development

No branches or pull requests
1 participant
@tomschr