fix booting from submenu (bsc #957893) #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boot option field was not properly setup immediately after entering or leaving a submenu. This caused the kernel commandline to be not properly assembled. Using the cursor keys in between corrected it, so this was noticeable only for the top submenu entry.
| @@ -207,7 +207,7 @@ | |||
| pop | |||
|
|
|||
| main.recalc | |||
| main.redraw | |||
| true main.redraw | |||
There was a problem hiding this comment.
I would find it more readable when using a symbol instead of a boolean parameter:
/with_boot_options main.redraw
/without_boot_options main.redraw
If I understand the language right, that would be translated with this argument parsing code prepended to main.redraw:
/with_boot_options eq true false ifelse
|
Just a suggestion, otherwise LGTM. |
wfeldt
added a commit
that referenced
this pull request
Dec 4, 2015
fix booting from submenu (bsc #957893)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boot option field was not properly setup immediately after entering or
leaving a submenu. This caused the kernel commandline to be not properly
assembled.
Using the cursor keys in between corrected it, so this was noticeable only
for the top submenu entry.