sanitize hostname handling (fate #319639) #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfeldt
added a commit
to yast/yast-yast2
that referenced
this pull request
May 9, 2016
install system has been fixed with these 2 PRs: openSUSE/linuxrc#108 openSUSE/installation-images#101
| log_debug("hostname = \"%s\"\n", buf); | ||
| if(*buf && strcmp(buf, "(none)")) file_write_str(f, key_hostname, buf); | ||
| } | ||
| } |
There was a problem hiding this comment.
What was purpose of this part. Why is it not needed anymore?
There was a problem hiding this comment.
That was added as a temporary solution to pass on the wicked-set hostname and is no longer needed.
|
One question which is caused by lack of knowledge about linuxrc. Otherwise LGTM |
|
LGTM. Thanks for the documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.