Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove invalid_hostname check (fate #319639) #467

Merged
merged 5 commits into from May 17, 2016
Merged

remove invalid_hostname check (fate #319639) #467

merged 5 commits into from May 17, 2016

Conversation

wfeldt
Copy link
Member

@wfeldt wfeldt commented May 9, 2016

this basically un-does:
#407

install system has been fixed with these 2 PRs:
openSUSE/linuxrc#108
openSUSE/installation-images#101

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 59.562% when pulling 6a78fa6 on fate_319639 into 78f7cfc on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 59.548% when pulling 1759c81 on fate_319639 into 78f7cfc on master.

@mchf
Copy link
Member

mchf commented May 16, 2016

LGTM

@@ -1,4 +1,10 @@
-------------------------------------------------------------------
Mon May 9 13:41:51 CEST 2016 - snwint@suse.de

- remove invalid_hostname check (fate #319639)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the guardian robots do not like the space between "fate" and "#".
You can run the check locally with rake check:changelog

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are right

@mvidner
Copy link
Member

mvidner commented May 17, 2016

(Removing) code looks good :)
Please make mergeable, then LGTM.

Conflicts:
	package/yast2.changes
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 60.053% when pulling c298848 on fate_319639 into 145c782 on master.

@wfeldt wfeldt merged commit 13d3498 into master May 17, 2016
@wfeldt wfeldt deleted the fate_319639 branch May 17, 2016 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants