-
Notifications
You must be signed in to change notification settings - Fork 49
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Travel Support Application useful for more organizations #78
Comments
Hello @ChrisBr and @ancorgs ! I have also sent the pull request regarding the same. Can you please see if I have interpreted the problem correctly? If yes, I'll proceed with implementing the same solution in the reimbursement page and also find a way to query by request number. Thank you |
@krngrvr09 great :) Any more questions? |
@krngrvr09 Sure. The models for the current state machines contain declarative code like this (extracted from assign_state :incomplete, :to => :requester
notify_state :incomplete, :to => [:requester, :tsp, :assistant],
:remind_to => :requester,
:remind_after => 5.days
assign_state :submitted, :to => :tsp
notify_state :submitted, :to => [:requester, :tsp, :assistant],
:remind_after => 10.days
assign_state :approved, :to => :requester
notify_state :approved, :to => [:requester, :tsp, :assistant],
:remind_to => :requester,
:remind_after => 5.days
notify_state :accepted, :to => [:requester, :tsp, :assistant]
notify_state :canceled, :to => [:requester, :tsp, :assistant]
# @see HasState.allow_transition
allow_transition :submit, :requester
allow_transition :approve, :tsp
allow_transition :accept, :requester
allow_transition :roll_back, [:requester, :tsp] Thanks to that, customizing the behavior of those classes is quite easy. But unfortunately that code is directly written in the model. That means that anyone wanting the change the behavior needs to change the core of the program, maybe being forced to keep a local branch in order to be able to update the instance and so on. Ideally, those DSL chunks should be in configuration files, so customizing an instance doesn't become a maintenance annoyance. |
Oh okay, that makes sense. Is there an IRC channel where I can discuss my interpretation of other issues and get my proposal reviewed? |
@ancorgs and me are both in #opensuse-project @ freenode, I'm not aware of any other IRC channel. |
Thanks @ChrisBr |
Mostly done |
Description: TSP is a Ruby on Rails based application to manage the requests and reimbursements from travel help programs of free software organizations. Originally developed for the openSUSE Travel Support Program it was adopted recently by the KDE e.V. Travel Cost Reimbursement initiative. This project is about making the tool more useful for KDE e.V. and possible future adopters. That includes:
Deliverable: A new version of the TSP application that covers as many points as possible from the list above.
Mentor: @ChrisBr / cbruckmayer@suse.de and @ancorgs / ancor@suse.com
Skills: Ruby on Rails
Skill Level: Medium
Get started: Install the application and implement something useful (with tests), like the improved search or any other feature. Fixes related to usability would be specially appreciated.
Github: https://github.com/openSUSE/travel-support-program
The text was updated successfully, but these errors were encountered: