Update navbar #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellcp
requested changes
Feb 29, 2020
hellcp
approved these changes
Feb 29, 2020
hellcp
reviewed
Feb 29, 2020
guoyunhe
force-pushed
the
search-box-mobile
branch
from
f7083cd
to
1108fd4
Compare
|
Are you gonna do more here or should I merge? |
|
Wait for a moment. I found the logo SVG I have miss the |
|
It's not strictly required, but it's good to have ;) |
|
Looks good to me, ready to merge? |
|
I did a change in Chameleon JS to not insert icon when the svg is inline. It may take 1 hour to take effect on the CDN. So I need to check it again one hour later so I don't destroy the launch day of new website. 😿 |
|
Yup, let me know when you are ready |
|
Ready to go 💚 |
|
Thank you :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.1. How to create new post.
1.2. No need to initialize git submodules.
1.3. Bundle packages can be installed in project path, which is much easier for people who are not familiar with Ruby.
2.1. Add search icon.
2.2. Use DuckDuckGo site search instead GitHub search. The result list points directly to news website, instead of GitHub source files.
3.1. Use new icon set.
3.2. Add categories list.
3.3. Add link to create new post. (point to GitHub README)