Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow packets to overwrite the macro _build_insert_debug_package #471

Closed
wants to merge 1 commit into from

Conversation

rhabacker
Copy link
Contributor

Creating mingwxx projects require a different implementation for creating debug packages than native packages. To allow this, the_build_insert_debug_package macro is moved to the macros.build
file, making it overwritable by packages.

I tested this with a local osc installation.

Creating mingwxx projects require a different implementation for
creating debug packages than native packages. To allow this, the
_build_insert_debug_package macro is moved to the macros.build
file, making it overwritable by packages.

I tested this with a local osc installation.
@mlschroe
Copy link
Member

mlschroe commented Oct 19, 2018

This would only work if the "build" package always gets installed in the build environment, which is not the case. So the code should not package the file, but simply write it like with ~/.rpmmacros.

I'm a bit curious: with what do you overwrite the macro?

@rhabacker
Copy link
Contributor Author

mingw32 and mingw64 packages (https://build.opensuse.org/project/show/windows:mingw:win32 and https://build.opensuse.org/project/show/windows:mingw:win64) have their own process for creating debug packages based on historical decisions, which does not harmonize with the creation of native debug packages. Therefore, the repository option to create debug packages [1] is disabled for these projects as well.
However, this also means that for a package that contains cross compilers, for example, no native debug packages can be created.
With the patch it would be possible to make this possible again by using a changed variant of %_debug_package for the mentioned project with activation of [1].
Do you have a better idea how to solve this issue ?

@Conan-Kudo
Copy link
Member

Why not just override the the debuginfo generator macro? That's what we do for Fedora MinGW packages, and this works when porting the Fedora macros to openSUSE.

@rhabacker
Copy link
Contributor Author

rhabacker commented May 26, 2020

Why not just override the the debuginfo generator macro?

You are refering to https://fedoraproject.org/wiki/Packaging:Debuginfo#Useless_or_incomplete_debuginfo_packages_due_to_other_reasons

@adrianschroeter
Copy link
Member

Closing this, because this should be solved without a code change as proposed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants