Add autocomplete component #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for obs-patterns ready! Built with commit cc2c5cc |
dmarcoux
suggested changes
Oct 1, 2018
| layout: post | ||
| title: Autocomplete | ||
| category: components | ||
| description: Whenever a field have the ability of autocomplete its value we should add a hint in form of placeholder and |
There was a problem hiding this comment.
Whenever a field has the ability to autocomplete its value, (new comma) we should add (...)
| %span.input-group-text#search-icon-id | ||
| %i.fa.fa-search | ||
| %i.fas.fa-spinner.fa-spin.d-none | ||
| %input.form-control#input-id{type: 'text', placeholder: 'Type to autocomplete...'} |
There was a problem hiding this comment.
Missing spaces inside the brackets (so it should be like line 12). This would trigger Rubocop in OBS.
Have an autocomplete input field component to be based on
mdeniz
force-pushed
the
add_autocomplete_component
branch
from
c579f2b
to
cc2c5cc
Compare
|
Please re-review it @dmarcoux 👍 |
dmarcoux
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have an autocomplete input field component to be based on