Sort tar file list #168
Merged
Sort tar file list #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspiers
requested changes
Jun 18, 2017
There was a problem hiding this comment.
Sorry, I can't guess the motivation behind this, or why it needs the other CPython pull request. Please can you watch https://youtu.be/pU-VasVPNAs?t=5m14s and then adjust the commit message accordingly.
to generate tar files in a reproducible way. See https://reproducible-builds.org/ for why this matters. In addition to this change, to generate completely reproducible tarballs, the build system also needs python/cpython#2263
|
@bmwiedemann Thanks, now I think I understand. So to clarify, the CPython PR does not need to be merged before this one is merged, right? You were just mentioning that as an FYI relating to the reproducible build initiative as a whole? |
aspiers
approved these changes
Jun 20, 2017
|
yes. They are independent, but to generate reproducible tarballs in the end, it needs both of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort tar file list
to generate tar files in a reproducible way.
See https://reproducible-builds.org/ for why this matters.
In addition to this change,
to generate completely reproducible tarballs,
the build system also needs
python/cpython#2263