Skip to content

Commit

Permalink
[webui] Drop request link id attribute.
Browse files Browse the repository at this point in the history
The project_controller functional test is content with the CSS class
attribute.
  • Loading branch information
saschpe committed Nov 22, 2012
1 parent b9ec2cb commit 0ddb6ea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/webui/app/views/shared/_requests.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
<%= link_to(image_tag('req-showdiff.png', :size => '16x16',
alt: "Show #{reqtype(req)} request ##{req['id']}",
title: "Show #{reqtype(req)} request ##{req['id']}"),
{:controller => :request, :action => :show, :id => req['id']}, {:class => "request_link", :id => "request_link_#{req['id']}"})
{:controller => :request, :action => :show, :id => req['id']}, {:class => "request_link"})
-%>
<% if ae['source'] && ae['spkg'] %>
<%= link_to(image_tag('information.png', :size => '16x16', alt:
Expand Down

4 comments on commit 0ddb6ea

@saschpe
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, one could have added "request_table_id" to the request link id attribute, but it's not needed ATM, so it's better to remove it.

@coolo
Copy link
Member

@coolo coolo commented on 0ddb6ea Nov 22, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschpe
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, it's using 'tr#tr_request_1000_1', which is a different one. The above was introduced by my merge yesterday but it turned out that I don't need it for my test case

@coolo
Copy link
Member

@coolo coolo commented on 0ddb6ea Nov 22, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah

Please sign in to comment.