Merge pull request #2763 from Ana06/exit_cop

[ci] Enable Rails/Exit Rubocop cop

src/api/.rubocop.yml

@@ -252,6 +252,11 @@ Performance/StringReplacement:
 
 Rails:
   Enabled: true
+
+# Enforces that 'exit' calls are not used.
+Rails/Exit:
+  Exclude:
+    - 'lib/memory_dumper.rb'
 
 # Use `find_by` instead `where.first` and `where.take`
 Rails/FindBy:

src/api/.rubocop_todo.yml

@@ -111,16 +111,6 @@ Performance/CompareWithBlock:
 Rails/DynamicFindBy:
   Enabled: false
 
-# Offense count: 4
-# Configuration parameters: Include.
-# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb
-Rails/Exit:
-  Exclude:
-    - 'lib/**/*.rake'
-    - 'app/jobs/consistency_check.rb'
-    - 'config/deploy.rb'
-    - 'lib/memory_dumper.rb'
-
 # Offense count: 126
 Rails/FilePath:
   Enabled: false
@@ -626,7 +616,6 @@ Style/PercentLiteralDelimiters:
     - 'app/controllers/source_controller.rb'
     - 'app/controllers/webui/monitor_controller.rb'
     - 'app/models/package.rb'
-    - 'config/deploy.rb'
     - 'config/initializers/hoptoad.rb'
     - 'lib/engines/base.rb'
     - 'script/start_test_backend'
@@ -854,7 +843,6 @@ Style/StringLiteralsInInterpolation:
     - 'app/models/binary_release.rb'
     - 'app/models/full_text_search.rb'
     - 'app/models/issue_tracker.rb'
-    - 'config/deploy.rb'
     - 'db/checker.rb'
     - 'lib/activexml/transport.rb'
     - 'lib/tasks/cleanup_sessions.rake'

src/api/app/jobs/consistency_check.rb

@@ -48,7 +48,7 @@ def check_project(fix = nil)
     init
     if ENV['project'].blank?
       puts "Please specify the project with 'project=MyProject' on CLI"
-      exit(1)
+      return
     end
     begin
       project = Project.get_by_name(ENV['project'])