[ci] Enable Rails/Exit Rubocop cop

[Ana06]

No description provided.

[Ana06]

Enable the Rails/Exit Rubocop cop

[marcus-h]

diff --git a/src/api/config/deploy.rb b/src/api/config/deploy.rb index fda1d4f..020edb4 100644 --- a/src/api/config/deploy.rb +++ b/src/api/config/deploy.rb @@ -118,12 +118,11 @@ Dir.glob('**/*.rb').each do |f| unless system("ruby -c -d #{f} > /dev/null") puts "syntax error in #{f} - will not deploy" - exit 1 + return end end unless system("rails test") puts "Error on rails test - will not deploy" - exit 1 end end end

Hmm this might break existing deploy scripts, if they rely on $?. (silent assumption: capistrano correctly propagates the SystemExit...) Btw., is this script still in use at all?

[hennevogel]

Btw., is this script still in use at all?

No it is not and you can just delete it :-)

[Ana06]

@hennevogel

What it is not used is the test_suite task?

[hennevogel]

config/deploy.rb is not used

[Ana06]

@hennevogel

config/deploy.rb is not used

Then I guess that Capfile is not used neither as it is loading config/deploy

[hennevogel]

you guess right