Correct Style/IfUnlessModifier offense in jobs

openSUSE · Aug 20, 2020 · f640c04 · f640c04
1 parent 2838241
commit f640c04
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/api/.rubocop_todo.yml b/src/api/.rubocop_todo.yml
@@ -1365,7 +1365,6 @@ Style/IfUnlessModifier:
     - 'app/controllers/webui/search_controller.rb'
     - 'app/controllers/webui/users/notifications_controller.rb'
     - 'app/controllers/webui/webui_controller.rb'
-    - 'app/jobs/status_history_rescaler_job.rb'
     - 'app/mailers/event_mailer.rb'
     - 'app/mixins/build_log_support.rb'
     - 'app/mixins/has_attributes.rb'

diff --git a/src/api/app/jobs/status_history_rescaler_job.rb b/src/api/app/jobs/status_history_rescaler_job.rb
@@ -4,9 +4,7 @@ class StatusHistoryRescalerJob < ApplicationJob
   # this is called from a delayed job triggered by clockwork
   def perform
     maxtime = StatusHistory.maximum(:time)
-    if maxtime
-      StatusHistory.where('time < ?', maxtime - 365 * 24 * 3600).delete_all
-    end
+    StatusHistory.where('time < ?', maxtime - 365 * 24 * 3600).delete_all if maxtime
 
     keys = StatusHistory.distinct.pluck(:key)
     keys.each do |key|