Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing validation for project in Staging:Workflow #7175

Closed
Ana06 opened this issue Mar 13, 2019 · 4 comments · Fixed by #10603
Closed

Missing validation for project in Staging:Workflow #7175

Ana06 opened this issue Mar 13, 2019 · 4 comments · Fixed by #10603
Labels
Bug Frontend Things related to the OBS RoR app good first issue Easy task, perfect for a first contribution

Comments

@Ana06
Copy link
Member

Ana06 commented Mar 13, 2019

From src/api/app/models/staging/workflow.rb:

 parent = Project.find_or_initialize_by(name: "#{project.name}:Staging:#{letter}")

which is called in an after create. But it is not compulsory to have a project (at least there is not validation) which causes:

undefined method name' for nil:NilClass`

Solution: Add the validation and not allow to have an staging workflow without a project and fixed everything this breaks.

@Ana06 Ana06 added Bug Frontend Things related to the OBS RoR app good first issue Easy task, perfect for a first contribution junior 👶 labels Mar 13, 2019
@ibrahimmohelsayed
Copy link

@Ana06 can i work on it ?

@dmarcoux
Copy link
Contributor

@ibrahimelbanna Sure, go ahead.

@manishnagdewani96170
Copy link

@dmarcoux IS this issue closed or can I also work on it?

@dmarcoux
Copy link
Contributor

dmarcoux commented Aug 8, 2019

@manishnagdewani96170 Sure, go ahead. We never heard back from @ibrahimelbanna.

@dmarcoux dmarcoux changed the title validation for project in Staging:Worklow missed Missing validation for project in Staging:Workflow Aug 31, 2020
bjoernalbers added a commit to bjoernalbers/open-build-service that referenced this issue Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Frontend Things related to the OBS RoR app good first issue Easy task, perfect for a first contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants