-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document person show endpoint #10633
Merged
danidoni
merged 1 commit into
openSUSE:master
from
danidoni:document-person-show-action
Jan 20, 2021
Merged
Document person show endpoint #10633
danidoni
merged 1 commit into
openSUSE:master
from
danidoni:document-person-show-action
Jan 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcoux
reviewed
Jan 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the commit message: endpoint instead of endpoing
danidoni
force-pushed
the
document-person-show-action
branch
from
January 18, 2021 11:20
21f7208
to
ac36112
Compare
dmarcoux
reviewed
Jan 18, 2021
danidoni
force-pushed
the
document-person-show-action
branch
3 times, most recently
from
January 18, 2021 17:04
0c55b7f
to
dab42a4
Compare
eduardoj
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would merge the commits into the first one.
dmarcoux
approved these changes
Jan 19, 2021
danidoni
force-pushed
the
document-person-show-action
branch
2 times, most recently
from
January 19, 2021 14:38
6983e7b
to
79ed0dc
Compare
The OpenAPI documentation for the `person#show` action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenAPI documentation for the
person#show
action.Replace this line with a description of your changes. Please follow the suggestions in the comment below.
If this PR requires any particular action or consideration before deployment,
please check the reasons or add your own to the list:
[1] https://github.com/openSUSE/open-build-service/wiki/Deployment-of-build.opensuse.org#when-there-are-migrations
[2] https://github.com/openSUSE/open-build-service/wiki/Feature-Toggles-%28Flipper%29#you-want-real-people-to-test-your-feature