Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force html processing for all formats except html, js and json #10874

Closed
wants to merge 1 commit into from

Conversation

danidoni
Copy link
Contributor

@danidoni danidoni commented Mar 15, 2021

The default html format makes the Cancel button to be processed wrongly as html
instead of js.

This change allows the Cancel button to work as ajax, as well as the rendering
of package pages for packages with dots in its name like
"yaml-cpp.openSUSE_Leap_15.2_Update".

Fixes #10510


If this PR requires any particular action or consideration before deployment,
please check the reasons or add your own to the list:

  • Requires a database migration that can cause downtime. Postpone deployment until maintenance window[1].
  • Contains a data migration that can cause temporary inconsistency, so should be run at a specific point of time.
  • Changes some configuration files (e.g. options.yml), so the changes have to be applied manually in the reference server.
  • A new Feature Toggle[2] should be enabled in the reference server.
  • Proper documentation or announcement has to be published upfront since the introduced changes can confuse the users.

[1] https://github.com/openSUSE/open-build-service/wiki/Deployment-of-build.opensuse.org#when-there-are-migrations
[2] https://github.com/openSUSE/open-build-service/wiki/Feature-Toggles-%28Flipper%29#you-want-real-people-to-test-your-feature

The default html format makes the Cancel button to be processed wrongly as html
instead of js.

This change allows the Cancel button to work as ajax, as well as the rendering
of package pages for packages with dots in its name like
"yaml-cpp.openSUSE_Leap_15.2_Update".

Fixes openSUSE#10510
@dmarcoux dmarcoux added the Frontend Things related to the OBS RoR app label Mar 15, 2021
@dmarcoux
Copy link
Contributor

I would be interested to know why is this needed for a package, but not for a project. Why?

@danidoni
Copy link
Contributor Author

danidoni commented Mar 15, 2021

I would be interested to know why is this needed for a package, but not for a project. Why?

Because we're forcing a specific format for packages but not for projects.

So a project can choose whatever format it needs for the response, but a package is forced to be treated as an :html no matter what.

@saraycp saraycp added the review-app Apply this label if you want a review app started label Mar 15, 2021
@obs-bot
Copy link
Collaborator

obs-bot commented Mar 15, 2021

Review app will appear here: http://obs-reviewlab.opensuse.org/danidoni-fix-cancel-button

@danidoni
Copy link
Contributor Author

I've opted for closing this PR in favor of #10879, because the new changes imply moving the Edit link close to the edited fields.

@danidoni danidoni deleted the fix-cancel-button branch March 17, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app review-app Apply this label if you want a review app started
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit package description: Cancel button not working
4 participants