Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package edit action close to the target #10879

Conversation

danidoni
Copy link
Contributor

@danidoni danidoni commented Mar 15, 2021

Following the conventions used for editing the details of a kiwi image, I've:

  • Moved the "Edit Package" button close to the edited details.
  • Reimplemented the Cancel button without ajax.
  • Fixed some markup issues when saving the modified details

Before
image

After
image

Supersedes #10874

Fixes #10510

How to review it:

  • Go to a package overview
  • Click on the "Edit" button below the package details. The package details get replaced by a form to edit those details.
  • Click on Cancel to get the package details back.

Replace this line with a description of your changes. Please follow the suggestions in the comment below.


If this PR requires any particular action or consideration before deployment,
please check the reasons or add your own to the list:

  • Requires a database migration that can cause downtime. Postpone deployment until maintenance window[1].
  • Contains a data migration that can cause temporary inconsistency, so should be run at a specific point of time.
  • Changes some configuration files (e.g. options.yml), so the changes have to be applied manually in the reference server.
  • A new Feature Toggle[2] should be enabled in the reference server.
  • Proper documentation or announcement has to be published upfront since the introduced changes can confuse the users.

[1] https://github.com/openSUSE/open-build-service/wiki/Deployment-of-build.opensuse.org#when-there-are-migrations
[2] https://github.com/openSUSE/open-build-service/wiki/Feature-Toggles-%28Flipper%29#you-want-real-people-to-test-your-feature

@danidoni danidoni force-pushed the move-package-edit-action-close-to-the-target branch from 43e8f98 to cf6d555 Compare March 15, 2021 15:02
@danidoni danidoni force-pushed the move-package-edit-action-close-to-the-target branch 2 times, most recently from e1732dc to c03f42c Compare March 15, 2021 16:25
@dmarcoux dmarcoux added the Frontend Things related to the OBS RoR app label Mar 15, 2021
@danidoni danidoni force-pushed the move-package-edit-action-close-to-the-target branch 3 times, most recently from 33700de to f8e08eb Compare March 16, 2021 15:31
@danidoni danidoni marked this pull request as ready for review March 16, 2021 16:36
@danidoni danidoni force-pushed the move-package-edit-action-close-to-the-target branch from f8e08eb to 63396b2 Compare March 17, 2021 09:10
Following the conventions used for editing the details of a kiwi image, we're
moving the "Edit Package" button close to the edited details.
@dmarcoux
Copy link
Contributor

It works well. It would be nice to have a transition animation when showing the form after clicking on Edit.

Copy link
Contributor

@dmarcoux dmarcoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animation can be in another PR.

@dmarcoux dmarcoux merged commit 197ce1a into openSUSE:master Mar 18, 2021
@danidoni danidoni deleted the move-package-edit-action-close-to-the-target branch March 18, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit package description: Cancel button not working
2 participants