-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move package edit action close to the target #10879
Merged
dmarcoux
merged 1 commit into
openSUSE:master
from
danidoni:move-package-edit-action-close-to-the-target
Mar 18, 2021
Merged
Move package edit action close to the target #10879
dmarcoux
merged 1 commit into
openSUSE:master
from
danidoni:move-package-edit-action-close-to-the-target
Mar 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danidoni
force-pushed
the
move-package-edit-action-close-to-the-target
branch
from
March 15, 2021 15:02
43e8f98
to
cf6d555
Compare
dmarcoux
reviewed
Mar 15, 2021
danidoni
force-pushed
the
move-package-edit-action-close-to-the-target
branch
2 times, most recently
from
March 15, 2021 16:25
e1732dc
to
c03f42c
Compare
danidoni
force-pushed
the
move-package-edit-action-close-to-the-target
branch
3 times, most recently
from
March 16, 2021 15:31
33700de
to
f8e08eb
Compare
5 tasks
dmarcoux
reviewed
Mar 17, 2021
dmarcoux
reviewed
Mar 17, 2021
dmarcoux
reviewed
Mar 17, 2021
danidoni
force-pushed
the
move-package-edit-action-close-to-the-target
branch
from
March 17, 2021 09:10
f8e08eb
to
63396b2
Compare
Following the conventions used for editing the details of a kiwi image, we're moving the "Edit Package" button close to the edited details.
It works well. It would be nice to have a transition animation when showing the form after clicking on |
dmarcoux
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The animation can be in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the conventions used for editing the details of a kiwi image, I've:
Before
After
Supersedes #10874
Fixes #10510
How to review it:
Replace this line with a description of your changes. Please follow the suggestions in the comment below.
If this PR requires any particular action or consideration before deployment,
please check the reasons or add your own to the list:
[1] https://github.com/openSUSE/open-build-service/wiki/Deployment-of-build.opensuse.org#when-there-are-migrations
[2] https://github.com/openSUSE/open-build-service/wiki/Feature-Toggles-%28Flipper%29#you-want-real-people-to-test-your-feature