Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check pull/merge request actions before initializing dependencies #12076

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Check pull/merge request actions before initializing dependencies #12076

merged 2 commits into from
Jan 18, 2022

Conversation

rubhanazeem
Copy link
Member

Fixes #11853

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Jan 13, 2022
@rubhanazeem rubhanazeem force-pushed the ignore-pull-merge branch 2 times, most recently from 6e9467c to 166c4fc Compare January 13, 2022 16:08
@rubhanazeem rubhanazeem force-pushed the ignore-pull-merge branch 3 times, most recently from 1a2bfcd to 3c34da4 Compare January 14, 2022 11:46
saraycp
saraycp requested changes Jan 14, 2022
View reviewed changes
src/api/app/controllers/trigger_workflow_controller.rb Outdated Show resolved Hide resolved
src/api/app/models/scm_webhook.rb Outdated Show resolved Hide resolved
@rubhanazeem rubhanazeem force-pushed the ignore-pull-merge branch 2 times, most recently from 33120d0 to 26b881f Compare January 14, 2022 14:52
@codecov
Copy link

codecov bot commented Jan 14, 2022 •
edited
Loading

Codecov Report

Merging #12076 (550f59c) into master (52547d1) will increase coverage by 0.03%.
The diff coverage is 94.02%.

❗ Current head 550f59c differs from pull request most recent head b22c065. Consider uploading reports for the commit b22c065 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12076      +/-   ##
==========================================
+ Coverage   91.25%   91.28%   +0.03%     
==========================================
  Files         640      642       +2     
  Lines       22675    22736      +61     
==========================================
+ Hits        20691    20754      +63     
+ Misses       1984     1982       -2

@rubhanazeem rubhanazeem marked this pull request as ready for review January 14, 2022 15:22
@dmarcoux dmarcoux self-requested a review January 17, 2022 10:25
@dmarcoux
Copy link
Contributor

As discussed with @rubhanazeem, I pushed a commit with my proposal for some minor improvements. Feel free to squash or drop the commit 🙂

@rubhanazeem rubhanazeem force-pushed the ignore-pull-merge branch 2 times, most recently from d658228 to 05d831f Compare January 18, 2022 10:37
@rubhanazeem
Check pull/merge request actions before initializing dependencies
f3f1aa9 
Co-authored-by: Dany Marcoux <dmarcoux@suse.com>
@rubhanazeem
Specs updates for trigger_workflow_controller and workflow_controller
b22c065 
Update specs to verify we don't create workflow_run entry when SCM event
is not supported

Co-authored-by: Dany Marcoux <dmarcoux@suse.com>
@dmarcoux dmarcoux requested a review from saraycp January 18, 2022 14:32
@saraycp saraycp merged commit a255643 into openSUSE:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danidoni danidoni danidoni left review comments

@dmarcoux dmarcoux dmarcoux approved these changes

@saraycp saraycp saraycp approved these changes

Assignees
No one assigned
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScmWebhookEventValidator too strict
4 participants
@rubhanazeem @dmarcoux @danidoni @saraycp