Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back repository status help #14316

Merged
merged 1 commit into from
May 17, 2023

Conversation

hennevogel
Copy link
Member

@hennevogel hennevogel commented May 11, 2023

This has been lost in 0b22ee5 and now got way more important with #14151

It was especially confusing if you have a broken repository that did not build anything yet. Because then you can't get to the repository status help anywhere, just the icon.

buildresults

You can "break" a project config by adding this

%if %_repository == 15.4
%define _is_tumbling weed
%else
%define _is_not_tumbling weed
%endif

or just look at https://build.opensuse.org/project/show/home:hennevogel:adaasa

This has been lost in 0b22ee5

It was especially confusing if you have a broken repository
that did not build anything yet. Because then you can't get to
the repository status help anywhere, just the icon.
@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label May 11, 2023
@hennevogel
Copy link
Member Author

hennevogel commented May 11, 2023

BTW one more reason to untie repository state info from the build results summary help. If you don't have any builds you can't get to the repository help...

Screenshot from 2023-05-11 19-04-09

@ncounter ncounter added the review-app Apply this label if you want a review app started label May 17, 2023
@obs-bot
Copy link
Collaborator

obs-bot commented May 17, 2023

Review app will appear here: http://obs-reviewlab.opensuse.org/hennevogel-bugfixrepo-state

Copy link
Contributor

@ncounter ncounter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hennevogel hennevogel merged commit ae8d7ad into openSUSE:master May 17, 2023
@hennevogel hennevogel deleted the bugfix/repo-state branch June 27, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app review-app Apply this label if you want a review app started
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants